Skip to content

feat: implement issue #430 — [Fleet Monitor] petry-projects/.github-private — sonarcloud.yml - #475

Merged
don-petry merged 6 commits into
mainfrom
dev-lead/issue-430-20260608-0044
Jun 8, 2026
Merged

don-petry merged 6 commits into
mainfrom
dev-lead/issue-430-20260608-0044

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Closes #430

Implemented by dev-lead agent. Please review.

@don-petry
don-petry requested a review from a team as a code owner June 8, 2026 00:51
Copilot AI review requested due to automatic review settings June 8, 2026 00:51
@coderabbitai

coderabbitai Bot commented Jun 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 11 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 456f6f5c-b746-4b63-ae12-561eb0d5473e

📥 Commits

Reviewing files that changed from the base of the PR and between 9c3e86e and 1826674.

📒 Files selected for processing (1)
  • .github/workflows/sonarcloud.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-430-20260608-0044

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce the elevated failure rate flagged in issue #430 by making the sonarcloud.yml workflow explicitly provision a JDK (Temurin 21) and directing the Sonar scanner to use that Java executable during analysis.

Changes:

  • Add an actions/setup-java step to install JDK 21.
  • Pass a -Dsonar.scanner.javaExePath=... argument to the Sonar scan action to use the installed JDK.

Comment thread .github/workflows/sonarcloud.yml Resolved
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — rate-limited (intent: fix-bot-comment)

PR: #475
Please re-trigger manually (re-mention @dev-lead) when the rate limit clears — the original request cannot be reconstructed automatically.

@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:39
@don-petry
don-petry disabled auto-merge June 8, 2026 01:41
@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I received your request but all AI engines are currently rate-limited. Please re-mention @dev-lead when the rate limit clears (estimated: unknown) — I cannot reconstruct the original instruction automatically.

@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:41
@don-petry
don-petry disabled auto-merge June 8, 2026 01:41
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:42
@don-petry
don-petry disabled auto-merge June 8, 2026 01:42
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:42
@don-petry
don-petry disabled auto-merge June 8, 2026 01:43
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:43
@don-petry
don-petry disabled auto-merge June 8, 2026 01:43
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:44
@don-petry
don-petry disabled auto-merge June 8, 2026 01:44
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:44
@don-petry
don-petry disabled auto-merge June 8, 2026 01:45
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:45
@don-petry
don-petry disabled auto-merge June 8, 2026 01:45
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:46
@don-petry
don-petry disabled auto-merge June 8, 2026 01:46
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:46
@don-petry
don-petry disabled auto-merge June 8, 2026 01:46
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 01:47
@don-petry
don-petry disabled auto-merge June 8, 2026 02:00
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 02:01
@don-petry
don-petry disabled auto-merge June 8, 2026 02:01
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 02:01
@don-petry
don-petry disabled auto-merge June 8, 2026 02:02
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 02:02
@don-petry
don-petry disabled auto-merge June 8, 2026 02:02
@don-petry
don-petry enabled auto-merge (squash) June 8, 2026 02:03
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — rate-limited (intent: on-mention)

PR: #475
Please re-trigger manually (re-mention @dev-lead) when the rate limit clears — the original request cannot be reconstructed automatically.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #475
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-08T06:01:17Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-08T06:01:17Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): Quality Gate passed badge comment — 0 new issues, 0 hotspots, no review threads to resolve
```
The PR is clean. No changes are needed in response to the SonarCloud bot comment.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 7ad2d26a773998036b0a483abfcb09095945209f
Review mode: triage-approved (single reviewer)

Summary

Workflow-only change to .github/workflows/sonarcloud.yml: adds an actions/setup-java@v5.2.0 step (SHA-pinned) to pre-install Temurin JDK 21, then passes -Dsonar.scanner.javaExePath=${{ steps.setup_java.outputs.path }}/bin/java to the SonarCloud scan action. This makes the scan use the locally provisioned JRE instead of downloading one from scanner.sonarcloud.io/jres/..., which was returning HTTP 403 during the failure window documented in #430.

Triage tier flagged this PR as low-risk; confirmation review concurs. Nine added lines, zero deletions, one file changed.

Linked issue analysis

#430 reports a 19% failure rate on sonarcloud.yml (8/42 runs). Dev-lead's root-cause comment on the issue traces all 8 failures to identical HTTP 403 Forbidden responses when the scanner attempted to download OpenJDK21U-jre_x64_linux_hotspot_21.0.9_10.tar.gz from SonarCloud's own JRE endpoint. Pre-installing the JRE locally and pointing the scanner at it via sonar.scanner.javaExePath removes that external dependency entirely — proportionate, targeted fix for the documented failure mode.

Findings

  • Action pinning ✓ — actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 verified against the v5.2.0 tag via the GitHub API; comment matches.
  • Output reference ✓ — steps.setup_java.outputs.path is the documented path output of actions/setup-java (same as $JAVA_HOME); appending /bin/java yields the executable. The id (setup_java) and the ${{ steps.setup_java.outputs.path }} reference use the same underscore form and are consistent.
  • Conditional unchanged ✓ — The scan step retains its if: ${{ env.SONAR_TOKEN != '' }} guard. The new setup-java step runs unconditionally, which is a minor inefficiency when SONAR_TOKEN is absent but has no functional impact; not worth gating.
  • Permissions ✓ — Job permissions (contents: read, pull-requests: read) and top-level permissions: {} are unchanged.
  • No security smells — No secrets exposure, no shell injection surface (the interpolated value comes from a trusted action's output, not user input), no new network egress beyond what setup-java itself does.
  • Org standards ✓ — Not a thin caller stub; SHA-pinned with version comment per AGENTS.md conventions.

CI status

All required checks green on 7ad2d26:

  • CodeRabbit: APPROVED
  • SonarCloud Quality Gate: PASSED (0 new issues, 0 security hotspots)
  • CodeQL (actions, python): SUCCESS
  • Lint (shellcheck, bats, validate-agent-profiles, gh-aw-compile, Compile agentic workflows): SUCCESS
  • CI (ShellCheck, Agent Security Scan, Secret scan / gitleaks): SUCCESS
  • AgentShield, Tests (unit-tests), Dependency audit: SUCCESS / appropriately SKIPPED

Merge state is BEHIND (branch needs rebase onto current main) but mergeable: MERGEABLE — routine and not a review blocker.


Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): Quality Gate Passed — 0 new issues, 0 security hotspots,
  0% duplication; no open review threads from sonarqubecloud[bot]; no hotspot
  patterns (curl|bash, hardcoded creds, eval, HTTP URLs) found in changed files.
```

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 0
Notes: Quality Gate passed — 0 new issues, 0 security hotspots, 0 duplications.
       No open review threads from sonarqubecloud[bot] to resolve.
       No Tier 1 CI blockers (no failure/timed_out/cancelled conclusions).
       All other checks are queued (pending); no action required.
```

@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 1826674596eece1c377c03876227c714ca497c59
Review mode: triage-approved (single reviewer)

Summary

Workflow-only change to .github/workflows/sonarcloud.yml: adds an actions/setup-java@v5.2.0 step (SHA-pinned) to pre-install Temurin JDK 21, then passes -Dsonar.scanner.javaExePath=${{ steps.setup_java.outputs.path }}/bin/java to the SonarCloud scan action. This makes the scan use the locally provisioned JRE instead of downloading one from scanner.sonarcloud.io/jres/..., which was returning HTTP 403 during the failure window documented in #430.

This is a confirmation review after the prior approved review at 7ad2d26. Since that review, only merge commits from main have been added — the PR's own 9-line diff is unchanged. Triage tier flagged this PR as low-risk; confirmation review concurs.

Linked issue analysis

#430 reports a 19% failure rate on sonarcloud.yml (8/42 runs). All 8 failures traced to identical HTTP 403 Forbidden responses when the scanner attempted to download OpenJDK21U-jre_x64_linux_hotspot_21.0.9_10.tar.gz from SonarCloud's own JRE endpoint. Pre-installing the JRE locally and pointing the scanner at it via sonar.scanner.javaExePath removes that external dependency entirely — proportionate, targeted fix for the documented failure mode.

Findings

  • No new code changes since prior approval — git compare 7ad2d26...1826674 shows only merge commits and unrelated files from main (#485, #476, #481). The PR's own diff against base is identical to what was previously approved.
  • Action pinning ✓ — actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 pins to v5.2.0; comment matches.
  • Output reference ✓ — steps.setup_java.outputs.path is the documented path output of actions/setup-java; appending /bin/java yields the executable. The id (setup_java) and the ${{ steps.setup_java.outputs.path }} reference are consistent.
  • Conditional unchanged ✓ — The scan step retains its if: ${{ env.SONAR_TOKEN != '' }} guard. The new setup-java step runs unconditionally, which is a minor inefficiency when SONAR_TOKEN is absent but has no functional impact; not worth gating.
  • Permissions ✓ — Job permissions (contents: read, pull-requests: read) and top-level permissions: {} are unchanged.
  • No security smells — No secrets exposure, no shell injection surface (interpolated value comes from a trusted action's output, not user input), no new network egress beyond what setup-java itself does.
  • Org standards ✓ — Not a thin caller stub; SHA-pinned with version comment per AGENTS.md conventions.

CI status

All required checks green on 1826674:

  • CodeRabbit: APPROVED
  • SonarCloud Quality Gate: PASSED (0 new issues, 0 security hotspots, 0% duplication)
  • CodeQL (actions, python): SUCCESS
  • Lint (shellcheck, bats, validate-agent-profiles, gh-aw-compile, Compile agentic workflows): SUCCESS
  • CI (ShellCheck, Agent Security Scan, Secret scan / gitleaks): SUCCESS
  • AgentShield, Tests (unit-tests): SUCCESS
  • Dependency audit: SUCCESS / appropriately SKIPPED per ecosystem

Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet Monitor] petry-projects/.github-private — sonarcloud.yml

3 participants